Closed kwalcock closed 5 years ago
Hey @kwalcock: should .travis.yml be renamed something else as well?
That file can remain. Travis gets disabled elsewhere, via its own control panel.
Cool. Then, ready to merge?
On Fri, Oct 18, 2019 at 8:35 AM Keith Alcock notifications@github.com wrote:
That file can remain. Travis gets disabled elsewhere, via its own control panel.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/clulab/reach/pull/642?email_source=notifications&email_token=AAI75TXG757XQT4ZYMDBY43QPFDI5A5CNFSM4JB7ZBE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBSWV6I#issuecomment-543517433, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI75TQRNPU35MDTUSSYK3DQPFDI5ANCNFSM4JB7ZBEQ .
Thanks!
On October 18, 2019 at 9:06:47 AM, Keith Alcock (notifications@github.com) wrote:
Merged #642 https://github.com/clulab/reach/pull/642 into master.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/clulab/reach/pull/642?email_source=notifications&email_token=AAI75TS6U4PNJ3YGZQBZW73QPFG7NA5CNFSM4JB7ZBE2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUJLWVXI#event-2723637981, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI75TUAVVSOYZBSMYTYOYLQPFG7NANCNFSM4JB7ZBEQ .
Jenkins seems to be working, but so does Travis, and maybe this is therefore unnecessary. I'll let somebody else decide. If this is checked in, tests will run on Jenkins and I will unconfigure the tests on Travis.