clulab / reach

Reach Biomedical Information Extraction
Other
97 stars 39 forks source link

Reach release does not look right #709

Closed kwalcock closed 3 years ago

kwalcock commented 3 years ago

I tried to publish reach, using the usual "sbt release" and was surprised to see some output on the screen that seemed to mean that a snapshot version was being published. The screen at sonatype seems to confirm that's what happened, not just now but also for the previous release. It seems like we recently started trying to release versions for both Scala 2.11 and 2.12. Another screen makes it look like that didn't work. Another site seems to think that version 1.6.0 is missing for both versions of Scala. Something seems to have been going wrong. We were using quite old versions of the plugins before. Updating them alone didn't seem to help. I'm putting this here in case anyone else has insights before I start to investigate.

image image image

MihaiSurdeanu commented 3 years ago

Hmm... It's possible I screwed up the release of 1.6.0... And it looks like 1.6.1 never happened. Based on the CHANGES file, all changes in 1.6.1 should be 1.6.2, no?

And unfortunately, I have no idea why we're releasing snapshots...

MihaiSurdeanu commented 3 years ago

But it looks like the release process in processors is very different:

releaseProcess := Seq[ReleaseStep](
  checkSnapshotDependencies,
  inquireVersions,
  runClean,
  runTest,
  setReleaseVersion,
  ReleaseStep(action = Command.process("+publishSigned", _)),
  ReleaseStep(action = Command.process("sonatypeReleaseAll", _)),
  commitReleaseVersion,
  tagRelease,
  setNextVersion,
  commitNextVersion,
  pushChanges
)
MihaiSurdeanu commented 3 years ago

The above one is reach. The one in processors is:

releaseProcess := Seq[ReleaseStep](
  checkSnapshotDependencies,
  inquireVersions,
  runClean,
  runTest,
  setReleaseVersion,
  commitReleaseVersion,
  tagRelease,
  releaseStepCommandAndRemaining("+publishSigned"),
  setNextVersion,
  commitNextVersion,
  releaseStepCommandAndRemaining("sonatypeReleaseAll"),
  pushChanges
)
kwalcock commented 3 years ago

An update of build.sbt seemed to do the trick. Is it important to release a version 1.6.0 that was intended back in May?

image

MihaiSurdeanu commented 3 years ago

Thanks @kwalcock ! No, it's not important to release 1.6.0.