clulab / reach

Reach Biomedical Information Extraction
Other
97 stars 39 forks source link

Remove duplicates from overrides #747

Closed bgyori closed 3 years ago

bgyori commented 3 years ago

Fixes #746. Except for E3 where there is a genuine ambiguity that had to be resolved (I chose the protein family sense there), all the other duplicates were just redundant rows that could be deleted.

enoriega commented 3 years ago

The tests that fail here are fixed by PR #745. Perhaps we should merge that branch into master and then here to re-run Jenkins @kwalcock @MihaiSurdeanu

enoriega commented 3 years ago

I edited the tests to account for the new grounding of E3 (Simple_chemical -> Family). We can go back to the way they were if @MihaiSurdeanu or @bgyori think so necessary