clulab / reach

Reach Biomedical Information Extraction
Other
97 stars 39 forks source link

Generate KBs as SBT Task #748

Closed enoriega closed 3 years ago

enoriega commented 3 years ago

Created an SBT task (generateKBs) to update the NER files from the KB files. This task supersedes the shell scripts that had to be run outside of SBT for the same purpose.

Tun run it, just call sbt generateKBs

bgyori commented 3 years ago

You might want to also update the instructions here: https://github.com/clulab/reach/blob/master/bioresources/README.md#updating-the-ner-files

enoriega commented 3 years ago

@MihaiSurdeanu @kwalcock any comments before merging?

kwalcock commented 3 years ago

Thanks for the reminder. Please stand by. I think it's absolutely great that this works through sbt rather than a shell command. I'll try it out momentarily.

kwalcock commented 3 years ago

Very handy. I checked Linux and Windows. In general I'd like to reduce the reliance on shell scripts because they aren't portable. runAllTests.sh might be up soon. I often just run sbt test and forget that not everything or enough gets tested.

enoriega commented 3 years ago

That's certainly a good candidate. Each test is a native sbt task, so it should be possible compose them into a single task.