search

clulab / reach

Reach Biomedical Information Extraction
Other
97 stars 39 forks source link

Move most of decoupling logic to processors #752

Closed kwalcock closed 3 years ago

kwalcock commented 3 years ago

These changes accompany https://github.com/clulab/processors/pull/477. That is, if we are allowed to change processors in order to support this new reach functionality, this is how I'd do it just now.

Processors has been updated to 8.3.3-SNAPSHOT here, so this can't be used directly until the processors change is merged and processors is republished.

The second commit includes a manual reordering of the label priorities. This needs to be fixed with a design or convention change of some kind. I'll defer at least temporarily to others on that.

kwalcock commented 3 years ago

@enoriega, so you know among other things how that map was turned into a sequence.

kwalcock commented 3 years ago

These won't pass until processors has been republished.

kwalcock commented 3 years ago

These are passing now with the updated version of processors, @enoriega.

enoriega commented 3 years ago

Thanks @kwalcock !