Open kwalcock opened 1 year ago
The test https://github.com/clulab/reach/blob/c7397a4b979454854f0c4a39098d2c2bb31363a3/main/src/test/scala/org/clulab/reach/mentions/serialization/TestJSONSerializer.scala#L83 doesn't do anything except calculate the value false. It should instead fail. The bug that causes the false value is actually in processors and will be fixed soon. Still, a test should test.
false
This is coded and part of a PR.
kwalcock
commented
1 year ago kwalcock
commented
1 year ago
The test https://github.com/clulab/reach/blob/c7397a4b979454854f0c4a39098d2c2bb31363a3/main/src/test/scala/org/clulab/reach/mentions/serialization/TestJSONSerializer.scala#L83 doesn't do anything except calculate the value
false. It should instead fail. The bug that causes the false value is actually in processors and will be fixed soon. Still, a test should test.