search

clulab / reach

Reach Biomedical Information Extraction
Other
96 stars 39 forks source link

Add bioresources to build #803

Closed bgyori closed 10 months ago

bgyori commented 10 months ago

This PR makes a small change to build.sbt which allows bioresources to be made available when doing publishLocal. This is necessary for #802.

kwalcock commented 10 months ago

Thanks, again, @bgyori. I'm not sure what we should do with this. Since it is already in a branch, perhaps we should just leave it there for safe keeping. @enoriega may want to weigh in.

bgyori commented 10 months ago

I think this PR is not that controversial - it just adds bioresources to be created with publishLocal which "doesn't hurt" so to speak, so I think it could be merged. Though I might be missing something.

enoriega commented 10 months ago

@kwalcock I am surprised that I worked before given that the project does load resources from the bioresources subproject. Regardless, if it doesn't hurt I don't object

kwalcock commented 10 months ago

I just didn't want to presume. The aggregation will work not just for publishLocal, but also publish, release, and test as far as I know. The publish in particular would have consequences.

enoriega commented 10 months ago

The subproject only consists of assets, no code whatsoever. So I am not worried about it. What I am still puzzled by if how we could read the resources and config of that subproject if it wasn't aggregated before

kwalcock commented 10 months ago

The dependsOn is probably handling it. The processors subproject dependsOn bioresources.