search

clulab / scala-transformers

Scala interfaces to huggingface transformers and tokenizers
10 stars 0 forks source link

Revert to concat #54

Closed MihaiSurdeanu closed 8 months ago

MihaiSurdeanu commented 8 months ago

@kwalcock : Can you please review and merge?

kwalcock commented 8 months ago

I'd like to add some comments to build.sbt to explain that model version 0.1.0 is for when USE_CONCAT is true and that there are other versions for when it is false. I'm likely to forget how it works otherwise.

MihaiSurdeanu commented 8 months ago

good idea!

MihaiSurdeanu commented 8 months ago

It occurs to me that

val USE_CONCAT = true

leaves no way to change the value at runtime. Is this switch only for developers or should people who are using the library be able to change the value before using a LinearLayer to get the alternative behavior? If so, then it might need to be a var instead.

I will edit the CHANGES file, etc., before publishing again.

That is intentional. I would prefer that just us change this.

kwalcock commented 8 months ago

Sounds good. Merging. I should have asked if you do need it published.

MihaiSurdeanu commented 8 months ago

Thanks! And, yes, please publish it so I can't update the processors branch.