search

clustericious / Clustericious

2 stars 3 forks source link

URL formats stopped working with Mojolicious 6.32 #20

Closed plicease closed 8 years ago

plicease commented 8 years ago

Test log at the bottom. I will probably wait a couple of days to wait and see if it is a bug in Mojo or it is us. I don't think we actually use .yml and .json URL format modifiers, so I am inclined just to remove the test.

The relevant item in the change log:

6.32  2015-11-18
  - Deprecated Mojolicious::Routes::Pattern::format_regex.
  - Added support for new HTTP status code.
  - Improved router performance.
  - Improved Mojo::DOM::CSS performance slightly. (jamadam)
  - Fixed a few case-sensitivity and An+B notation bugs in Mojo::DOM::CSS.
    (jamadam)

I believe this is the code change:

https://metacpan.org/diff/file?target=SRI%2FMojolicious-6.32%2Flib%2FMojolicious%2FRoutes%2FPattern.pm&source=SRI%2FMojolicious-6.31%2Flib%2FMojolicious%2FRoutes%2FPattern.pm

iscah% prove -lv t/app.t 
t/app.t .. 
1..21
#  INFO Initialized logger
#  INFO Log config found : /tmp/1aliI2JeP3/my_home/etc/log4perl.conf
#  INFO No auth configured
#  WARN Configuration file should contain 'url'.
# DEBUG Helper "url_with" already exists, replacing
# DEBUG GET "/"
# DEBUG Routing to a callback
# DEBUG 200 OK (0.000932s, 1072.961/s)
ok 1 - GET /
ok 2 - 200 OK
ok 3 - got content
# DEBUG GET "/version"
# DEBUG Routing to a callback
# DEBUG 200 OK (0.000643s, 1555.210/s)
ok 4 - GET /version
ok 5 - GET /version
ok 6 - /version is correct
# DEBUG GET "/version.yml"
# DEBUG Routing to a callback
# DEBUG 200 OK (0.000642s, 1557.632/s)
ok 7 - GET /version.yml
ok 8 - GET /version.yml
ok 9 - Content-Type: text/x-yaml
ok 10 - /version.yml is correct
# DEBUG GET "/api/bogus_table"
# DEBUG Routing to a callback
# DEBUG Rendering template "not_found.development.html.ep" from DATA section
# DEBUG 404 Not Found (0.002897s, 345.185/s)
ok 11 - GET /api/bogus_table
ok 12 - 404 Not Found
# DEBUG GET "/api"
# DEBUG Routing to a callback
# DEBUG 200 OK (0.000888s, 1126.126/s)
ok 13 - GET /api
ok 14 - 200 OK
# DEBUG GET "/autotest"
# DEBUG Routing to a callback
# DEBUG 200 OK (0.000842s, 1187.648/s)
ok 15 - GET /autotest
ok 16 - 200 OK
ok 17 - exact match for JSON Pointer ""
# DEBUG GET "/autotest.yml"
# DEBUG Rendering template "not_found.development.html.ep" from DATA section
# DEBUG 404 Not Found (0.001952s, 512.295/s)
ok 18 - GET /autotest.yml
not ok 19 - 200 OK

#   Failed test '200 OK'
#   at t/app.t line 58.
#          got: '404'
#     expected: '200'
# NOT FOUND :  "/autotest.yml"
# DEBUG GET "/autotest_not_found"
# DEBUG Routing to a callback
# DEBUG Rendering template "not_found.development.html.ep" from DATA section
# DEBUG 404 Not Found (0.001481s, 675.219/s)
ok 20 - GET /autotest_not_found
ok 21 - 404 Not Found
# NOT FOUND :  "/autotest_not_found"
# detailed log
# [19080 I 0ms] /home/ollisg/dev/Clustericious/lib/Clustericious/Log.pm:113 Initialized logger
# [19080 I 1ms] /home/ollisg/dev/Clustericious/lib/Clustericious/Log.pm:114 Log config found : /tmp/1aliI2JeP3/my_home/etc/log4perl.conf
# [19080 T 1ms] /home/ollisg/dev/Clustericious/lib/Clustericious/Config.pm:211 could not find SomeService file.
# [19080 I 1ms] /home/ollisg/dev/Clustericious/lib/Clustericious/App.pm:141 No auth configured
# [19080 W 3ms] /home/ollisg/dev/Clustericious/lib/Clustericious/App.pm:159 Configuration file should contain 'url'.
# [19080 D 3ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious.pm:137 Helper "url_with" already exists, replacing
# [19080 D 8ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious.pm:104 GET "/"
# [19080 D 9ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Routes.pm:99 Routing to a callback
# [19080 D 9ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Controller.pm:211 200 OK (0.000932s, 1072.961/s)
# [19080 D 12ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious.pm:104 GET "/version"
# [19080 D 12ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Routes.pm:99 Routing to a callback
# [19080 D 13ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Controller.pm:211 200 OK (0.000643s, 1555.210/s)
# [19080 D 16ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious.pm:104 GET "/version.yml"
# [19080 D 16ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Routes.pm:99 Routing to a callback
# [19080 D 16ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Controller.pm:211 200 OK (0.000642s, 1557.632/s)
# [19080 D 19ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious.pm:104 GET "/api/bogus_table"
# [19080 D 19ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Routes.pm:99 Routing to a callback
# [19080 D 21ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Plugin/EPLRenderer.pm:44 Rendering template "not_found.development.html.ep" from DATA section
# [19080 D 22ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Controller.pm:211 404 Not Found (0.002897s, 345.185/s)
# [19080 D 25ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious.pm:104 GET "/api"
# [19080 D 26ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Routes.pm:99 Routing to a callback
# [19080 D 26ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Controller.pm:211 200 OK (0.000888s, 1126.126/s)
# [19080 D 29ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious.pm:104 GET "/autotest"
# [19080 D 30ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Routes.pm:99 Routing to a callback
# [19080 D 30ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Controller.pm:211 200 OK (0.000842s, 1187.648/s)
# [19080 D 33ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious.pm:104 GET "/autotest.yml"
# [19080 D 35ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Plugin/EPLRenderer.pm:44 Rendering template "not_found.development.html.ep" from DATA section
# [19080 D 36ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Controller.pm:211 404 Not Found (0.001952s, 512.295/s)
# [19080 D 39ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious.pm:104 GET "/autotest_not_found"
# [19080 D 40ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Routes.pm:99 Routing to a callback
# [19080 D 40ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Plugin/EPLRenderer.pm:44 Rendering template "not_found.development.html.ep" from DATA section
# [19080 D 41ms] /home/ollisg/.perlbrew/libs/perl-5.23.4tc@dev/lib/perl5/Mojolicious/Controller.pm:211 404 Not Found (0.001481s, 675.219/s)
# Looks like you failed 1 test of 21.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/21 subtests 

Test Summary Report
-------------------
t/app.t (Wstat: 256 Tests: 21 Failed: 1)
  Failed test:  19
  Non-zero exit status: 1
Files=1, Tests=21,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.33 cusr  0.01 csys =  0.37 CPU)
Result: FAIL
plicease commented 8 years ago

There is something bogus about this test, because I just wrote t/hello_world.t which tests the same functionality with Clustericious::HelloWorld and it works fine.

plicease commented 8 years ago

I am pretty sure this is just a bogus test. closing.