search

clutcher / bh

Issue tracker for Better Highlights Intellij IDEA plugin
7 stars 0 forks source link

Not working with rider #13

Closed Gandalf-Le-Dev closed 1 year ago

Gandalf-Le-Dev commented 2 years ago

Hi as you can see on the screenshot the plugin is not working on rider image

I hope you can fix that Thanks

clutcher commented 2 years ago

@ArKeid0s Screenshot looks good. Can you provide more info?

Ares9323 commented 2 years ago

I'm not the author of this issue but I confirm it's not working for me in Rider 2022.1 with C++ It's working only inside comments: image

The "public" METHOD_KEYWORD is the plugin default and it's not working too (All colors are set, also tried setting background color thinking that they were overridden by the theme but nothing changes, also tried in a .txt file without any syntax highlighting with the same results, except that FRotator is highlighet as comment even if it's outside a comment) image

clutcher commented 2 years ago

@Ares9323 Can you send me file, where highlights are not working for you? I still can't reproduce it. And what OS you are using?

Ares9323 commented 2 years ago

@Ares9323 Can you send me file, where highlights are not working for you? I still can't reproduce it. And what OS you are using?

Sure, it doesn't work in any file created with Unreal Engine, so I'll send you two random .cpp and .h files

Edition Windows 10 Pro Version 21H2 Installed on ‎12/‎03/‎2021 OS build 19044.1645 Experience Windows Feature Experience Pack 120.2212.4170.0

This is also an example of the wanted result (My actual config in VSCode) image

clutcher commented 2 years ago

@Ares9323 I'm on Linux on Intellij 2021.1.3.

FRotaror is not an keyword, so it is not highlighting. Everything else is working as expected:

2022-05-05_22-28-49

2022-05-05_22-31-33

But I noticed that Intellij itself is lagging, so I need to cut public section in .h file and undo the cut to fix highlighting. And I just noticed that on your screenshot is .txt file, they support only comments for highlighting and could be buggy. Not sure what else I can check or do.

clutcher commented 2 years ago

@Ares9323 The more I'm looking into that the more I think that is is issue with rendering inside intellij itself.

Ares9323 commented 2 years ago

Sorry, I haven't had time to answer yesterday! Thank you for the support.

FRotaror is not an keyword, so it is not highlighting.

Sorry again, it's a variable type (and it's recognized by Rider since it reads the engine source code) so I thought it was considered as a "keyword", I also thought I could highlight any word (in vscode I use regex to do that) but apparently I'm wrong!

Also the macro UPROPERTY and UFUNCTION should be recognized as keywords.

It there's anything I could do to help you just ask, I'm also available for a remote session if you need

Do you have any tip or workaround to color these strings?

clutcher commented 1 year ago

Don't think that I can do anything with that. I will load a ticket to do some generic regexp highlighting disabled by default to not impact performance clutcher/better_highlights_bugtracker#7 .