search

clutcher / bh

Issue tracker for Better Highlights Intellij IDEA plugin
7 stars 0 forks source link

Add support for Javascript keyword highlighting #14

Closed gungun974 closed 2 years ago

gungun974 commented 2 years ago

Hello, I wanted to know if it was normal for this extension that I can't seem to change the color of a keyword ("public" in this example) in a Typescript file (".ts") or in a JavaScript file (".js"). (Yes I know that the public keyword does not exist in Javascript). Screen Shot 2021-12-29 at 22 01 28

clutcher commented 2 years ago

@gungun974 Coloring you can change in Editor -> Color Scheme -> Comments/Keywords

2021-12-31_12-44-07

clutcher commented 2 years ago

Also if it is not a language keyword - it wouln not be highlighted. Plugin works only for keywords and comments, not for any word in a text file.

gungun974 commented 2 years ago

Happy new years !

So i already change color foreground in the comment / keywords color scheme. It's work in Java, the "public" keyword change color but in JavaScript (".js") when i try with "var" keyword, it's does nothing. (And worst the color change of "var" work in Java files) I am sure it's a kind of bug or something missing in this plugin cause i will be very unlike that the JavaScript keyword "var" is not really a keyword for Jetbrain...

Maybe the answer to this is to create a JavaScriptKeywordHighlighterAnnotator.java and TypeScriptKeywordHighlighterAnnotator.java like you do for "PHP, CPP, C, C# Java and Koltin" but i know nothing about Jetbrain plugin development and how really work your plugin (Otherwise I would have tried something on my side and I would have already made a pull request).

Jimmy-JS commented 1 year ago

Hi @clutcher, sorry but I still has some problem with some of javascript syntax which I tried to change async and await syntax in javascript.

Here is my setting: image image

Result: image

As you can see, I'm trying to change await, async, and let color to light blue. for let it's working properly. but it doesn't change the color of the async and await and it still use the IDE javascript keyword color which is purple (is it because of the prioritization?). any work around for this?

Thanks before!

gungun974 commented 1 year ago

Hi @clutcher, sorry but I still has some problem with some of javascript syntax which I tried to change async and await syntax in javascript.

Here is my setting: image image

Result: image

As you can see, I'm trying to change await, async, and let color to light blue. for let it's working properly. but it doesn't change the color of the async and await and it still use the IDE javascript keyword color which is purple (is it because of the prioritization?). any work around for this?

Thanks before!

Hello. I can confirm I got the same result and the worst it's I never realized my "await" and "async" are in wrongs colors before.

I don't thinks it's not possible to fix this since already all other keywords works correctly. (I suppose cause I never change all keywords of colors...)

One thing you can try @Jimmy-JS is to change globally the JavaScript keyword color and then change every other keyword with your colors.

Just to finish I want to say this plugin is for me the best Plugin I can see on Idea and I'm glad to have make it's work for JS & TS cause it's just a pleasure to work with it.