clutcher / bh

Issue tracker for Better Highlights Intellij IDEA plugin
7 stars 0 forks source link

[PHPStorm] Highlighting does not work for phpdocs within a class #23

Closed ditsuke closed 3 years ago

ditsuke commented 3 years ago

It looks like while highlighting is working for phpdocs, it fails for phpdocs that are within a class.

image

clutcher commented 3 years ago

@ditsuke Looks good on latest intellij:

2021-07-20_18-35-32

Are you on latest version?

ditsuke commented 3 years ago

Are you on latest version?

@clutcher Yes, I'm on the latest PHPStorm and Comment Highlighter, installed fresh from the marketplace.

clutcher commented 3 years ago

@ditsuke Checked on fresh PHPStorm with latest plugin version, looks good. Maybe some other plugin is causing that? Can you send a list of enabled plugins?

Also can you attach php file, where you have that issue. Maybe some strange symbol is inside.

ditsuke commented 3 years ago

@clutcher

image

ditsuke commented 3 years ago

It looks like the issue is with indented comments in general. It doesn't matter if they're outside a class:

image

clutcher commented 3 years ago

@ditsuke Was able to reproduce with your test file. Issue is that PHP doc comment in that case uses a special PhpDocToken instead of generic PsiComment. I'll work on it and prepare a new version in nearest few days.

P.S. Thanks for creating github ticket for that bug.

clutcher commented 3 years ago

Fix would be released in next few days