clutcher / bh

Issue tracker for Better Highlights Intellij IDEA plugin
7 stars 0 forks source link

Check possible performance issues #50

Closed clutcher closed 1 year ago

clutcher commented 1 year ago

Based on comment https://plugins.jetbrains.com/plugin/12895-better-highlights/reviews#review=84778.

"Performance. I have a reasonably fast machine and very rarely have to wait for colour rendering, but occasionally the custom colours will simply vanish from the editor tabs I am using. Sometimes they reappear later on their own; other times not until I reload the file. This is mildly annoying - not a waste of my time or a blocker, but a quality aspect that I feel should be fixed before asking for money."

clutcher commented 1 year ago

Never experienced such issues myself. From performance perspective there is not much to improve and most probably such behavior is a side effect of Intellij platform itself.

In Intellij platform 2023.1 was introduced possibility to make Annotators DumbAware, which should run highlighting without waiting for indexing to finish. Which should probably resolve issue with reappearing highlighting. I'll work on that implementation and hopefully it will resolve discribed issue.

clutcher commented 1 year ago

We will consider as resolved. In case any issues - it could be reopened.

clutcher commented 1 year ago

Reopen as one more user reported same issue.

https://plugins.jetbrains.com/plugin/12895-better-highlights/reviews#review=84778-86054

"I have the same performance problem that ithium mention at point two, sometimes I have to wait some minutes to re-apply the color to tokens, or just stop to write code

clutcher commented 1 year ago

Unfortrunatelly, I fixed all possigle glitches and issues in releases 2023.6.8 and 2023.6.3. Right now can't find any other issues and glitches with similar behavior.

Would be great if anyone could provide more information on that:

clutcher commented 1 year ago

Looks like it was issue from #51 with race condition and layer override.

clutcher commented 1 year ago

Looks like no more issue after 2023.7.1.