clutcher / bh

Issue tracker for Better Highlights Intellij IDEA plugin
7 stars 0 forks source link

C# and Regex mode syntax highlight issue #52

Closed quentin-pontonnier closed 1 year ago

quentin-pontonnier commented 1 year ago

I encountered a really minor problem with C# and regex mode highlight.

I wanted to use regex to highlight properties get and set keywords with paid version of your (awesome) plugin.

But even if the regex matches the keyword and it finds the keywords, the style properties (in my case color) is overridden by rider's color normally applied to the get & set keywords which is specified in settings "Editor > Color Scheme > C# > Methods > Method". It acts like for regex highlight in C# desired color is a lower priority than base color scheme when using regex highlighting at least for this case, cause it's the only case i used regex token matching but it might be rider specific, so if you have an idea to fix it that would be awesome!

Bye, and thank you for this plugin!

clutcher commented 1 year ago

@quentin-pontonnier You are right with your assumption about priorities. Unfortunatelly I can't just increase it for all tokens, as it will move highligting into another phase(weird implementation inside IDE).

As a fix I'll create a checkbox (regexp wide or per token) to use highest priority, so it will not impact other types of tokens/users.

clutcher commented 1 year ago

@quentin-pontonnier Can you give me your exact example, so I can verify it?

clutcher commented 1 year ago

Fix would be in next release 2023.7.1. Should be available on marketplace in 1-2 days.