clutcher / bh

Issue tracker for Better Highlights Intellij IDEA plugin
7 stars 0 forks source link

Link properties #76

Closed mgroth0 closed 8 months ago

mgroth0 commented 10 months ago

I suggest allowing linking to properties. In the example below, only the function is linked.

/*[[SomeClass#aFunction]]*/
/*[[SomeClass#aProperty]]*/
class SomeClass {
    fun aFunction() = Unit
    val aProperty = Unit
}
clutcher commented 10 months ago

@mgroth0 Sorry, for late response. I'll check if it is possible to implement and for which languages (somewhere in 1-2 weeks, after finishing rewriting settings UI for plugin). Looks like in your case you need Kotlin?

mgroth0 commented 10 months ago

Hey @clutcher . Thanks for considering this request, and no rush!

So, actually what I think I want to do is I link across languages. The links themselves are located in python files, but the targets of the links are kotlin. Currently, this is working well but only for functions, not properties.

clutcher commented 8 months ago

@mgroth0 Latest release 2023.8.7 now allows to reference properties. Can you check if it fulfills your needs?

mgroth0 commented 8 months ago

Hey @clutcher , Thank you for the effort on this.

Here is the issue. Links work for all cases except when the variable has a custom getter. See the screenshots below.

Screenshot 2023-12-09 at 3 09 55 PM Screenshot 2023-12-09 at 3 10 03 PM
clutcher commented 8 months ago

@mgroth0 Should be fixed in latest release 2023.8.8.

mgroth0 commented 8 months ago

Thanks again @clutcher . I can confirm that this fixed the issue above.

However, we still do not see links for inherited members:

Screenshot 2023-12-13 at 10 58 46 AM Screenshot 2023-12-13 at 10 58 54 AM
clutcher commented 8 months ago

@mgroth0 This is by initial design - it doesn't link methods/attributes of parent classes. I'll create a separate issue for that.

clutcher commented 8 months ago

Closing this one as initial issue were resolved.