search

clutcher / bh

Issue tracker for Better Highlights Intellij IDEA plugin
7 stars 0 forks source link

Highlights don't work unless editor highlighting level is set to "Hints" #77

Closed shayded-exe closed 8 months ago

shayded-exe commented 10 months ago

I often want to work without suggestions and warnings distracting me.

Setting the highlighting level to anything below Hints causes custom highlights to stop working.

image

clutcher commented 10 months ago

@shayded-exe Sorry, for delay in response, I almost finished rewriting settings UI for plugin. I thik in next week or so I'll make more deeper look in your problem.

Don't know exact root cause in your case, but I already fixed some bugs related to higlighting level and there is a big chance that I would introduce a separate setting of level per token, so you could select it for your use case. The reason is that some of highligts can be changed only with "hint" level (for example, java class files), while others can by changed only with error level (for example ulong in C).

clutcher commented 9 months ago

@shayded-exe Most probably, I will create a setting under each highlight toke, where you would be able to select severity. The only issue with that - if you would select Error severity, highlighting would be calculated as an error and be displayed in list of errors. I'm still looking if I can use syntaxHighlighter stuff from Intellij, which should be on "Syntax" level, but looks like it is pretty limited.

What exact highlighting are you using and would like to be shown on Syntax level? Comments, keywords, regexp?

shayded-exe commented 9 months ago

I see. For me keywords and comments. Primarily I use it to make public a different color.

I will say this has become less of an issue for me as I've started just turning off some warnings and suggestions altogether. I finally realized that many of the inspections really just get in my way and drive my OCD up a wall.

Hell I may switch back to vscode with all the little things that don't work properly in Rider.

clutcher commented 9 months ago

@shayded-exe keywords should be possible to switch on "syntax" level, so should help with your main use case. As for comments - can't say right now.

P.S. Don' know much about C# and Rider, but Java in Intellij is much better than VSCode. Especially all stuff related to refactorings like extract method/variable/parameter and opposite operation to inline method/variable.

clutcher commented 8 months ago

@shayded-exe hi, are you still using Rider? I released an update 2023.8.9, where you can now select level of highlighting.

shayded-exe commented 8 months ago

@shayded-exe hi, are you still using Rider? I released an update 2023.8.9, where you can now select level of highlighting.

Yes I am, and thank you this is great!

clutcher commented 8 months ago

@shayded-exe Great. Then closing the ticket.