Closed Brokenchin closed 11 months ago
Wanted to add that upgrading to 8.1 from 7.14. The set options from 7.14 are used but trying to change the values won't work in the new UI.
In this screenshot you can see the options are reset as if not being set.
Modifying this in any way does nothing to TODO comment: But it does change the doc comments color:
@Brokenchin Thanks for submitting bug, it was interesting. I pushed new version with fix.
@Brokenchin New version is already available on marketplace, you could update and check if everything is fixed now.
@clutcher I upgraded 8.1 to 8.2
Lets start with the good news:
document docs is no longer modified by the changes:
values are saved that I set in the New Ui and does persist for each type. But they are not applied and old values set in 7.14 is still used.
Also values set in 7.14 do not show up at all in new ui:
also last image had a glitch of doc comment not working but the clion simply refreshed or something to default comment color while in settings.
I tried closing the editor multiple times to see if it would work but it did not.
Reverted back to 7.14. Still works there.
Seem to retain 2 sets of color when upgrading to new one. in 7.14 I have the old colors.
After upgrade. the colors retain 8.2s color in settings but are not used. The old version colors are used.
@Brokenchin Just played around with clion and material darker theme - don't have any issues. So if you will open settings window put new color on add token, click Apply, click Ok and put a "space" in commented line with "add" token - would it work?
@clutcher
8.2 Nothing changes:
Applied and Pressed "Ok" tried to restart editor. nothing happened.
If I do the same in 7.14 The color changes on "Apply"
7.4:
@Brokenchin I see that in 7.4 screenshot you have "Visual studio ..." scheme, while on 8.2. you have "Material Dark". What color scheme you are using right now? Looks like you need to select "visual studio ..." scheme in new ui also.
P.S. @Brokenchin Thanks for fast responses and screenshots from both versions.
@Brokenchin I see that in 7.4 screenshot you have "Visual studio ..." scheme, while on 8.2. you have "Material Dark". What color scheme you are using right now? Looks like you need to select "visual studio ..." scheme in new ui also.
Interestingly you are correct. The color was applied on pressing "Ok"
@Brokenchin So now everything is ok? And I can close this ticket? Maybe you have any other issues or feature requests for this plugin?
@Brokenchin So now everything is ok? And I can close this ticket? Maybe you have any other issues or feature requests for this plugin?
Yes you can close the ticket. If I have suggestion will open a new one. I did not realize the plugin works per schema/color scheme. In fact I had to set it in Editor Color Schema like this to make it work.
Thank you for assist.
@Brokenchin Thank you too. Have a nice day.
Newest Update 2023.8.1 breaks the options for code highlighting.
Clion: CLion 2023.2.2
Trying to modify any of custom comment tokens wont work as intended. The values for color reset. Settings won't persist.
Only the default values can be modified and their color does persist. Had to revert back to 2023.7.14 to make my comment tokens work.
Comment Tokens I use as example:
This also applies to Other highlights
Keyword tokens I use as example: