search

clutcher / bh

Issue tracker for Better Highlights Intellij IDEA plugin
6 stars 0 forks source link

Add referencing of methods/functions in non OOP languages #92

Closed clutcher closed 5 months ago

clutcher commented 6 months ago

Initially requested by @MinionWare in #91 to allow referencing stored procedures in different sql files.

Right now wikiling suports only referencing via ClassName#MethodName, which is not applicable to non OOP cases, like stored procedures in SQL files or in languages like Go/Rust etc.

So there is a need to implement some ability to use wikiling to reference such functions/procedures.

clutcher commented 6 months ago

Right now I tend to use filename instead of class name. Something like:

// [[filename.sql#nameOfProcedure]]]

@MinionWare what do you think about that? Will it suite your needs?

MinionWare commented 6 months ago

I think that would be grand. Thanks man.

-Sean

[1506638742078_minionware]

From: Igor Zarvanskyi @.> Sent: Friday, December 29, 2023 03:27 To: clutcher/bh @.> Cc: Sean McCown @.>; Mention @.> Subject: Re: [clutcher/bh] Add referencing of methods/functions in non OOP languages (Issue #92)

Right now I tend to use filename instead of class name. Something like:

// [[filename.sql#nameOfProcedure]]]

@MinionWarehttps://github.com/MinionWare what do you think about that? Will it suite your needs?

— Reply to this email directly, view it on GitHubhttps://github.com/clutcher/bh/issues/92#issuecomment-1871929548, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADY75M2RDGJHMZMVAFNCNFLYL2LI5AVCNFSM6AAAAABBGOIA6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZRHEZDSNJUHA. You are receiving this because you were mentioned.Message ID: @.***>

MinionWare commented 6 months ago

I know you're working on this feature, and I have questions about how it'll work. In your above sample: // [[filename.sql#nameOfProcedure]]] would that go to a specific SP in a file with a bunch of SPs in it? Like going to a specific method in a class? That would be good, but also, most project files have only 1 SP in them so it should also be able to handle just a filename. I do have a request though... as long as you're linking to an SP in a file, can you also link to a comment token? I often mention specific comments across files and it would be good to be able to link directly to that spot in another file. What would be really cool though is if I could also hover over that external token and get a preview so I don't have to actually open the other file. Does that sound doable?

clutcher commented 6 months ago

@MinionWare

MinionWare commented 5 months ago

Yeah, it would be nice to see the comment when i hover over it from another file. Like Peek Definition in Visual Studio.

Sean McCown (817)937-6154 [cid:b0ca1321-9650-42ed-9857-eaf8456c5e3b]

From: Igor Zarvanskyi @.> Sent: Wednesday, January 17, 2024 09:35 To: clutcher/bh @.> Cc: Sean McCown @.>; Mention @.> Subject: Re: [clutcher/bh] Add referencing of methods/functions in non OOP languages (Issue #92)

@MinionWarehttps://github.com/MinionWare

— Reply to this email directly, view it on GitHubhttps://github.com/clutcher/bh/issues/92#issuecomment-1896180511, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADY75MYM7C43Q6XWBRKUN5LYO74VTAVCNFSM6AAAAABBGOIA6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJWGE4DANJRGE. You are receiving this because you were mentioned.Message ID: @.***>

MinionWare commented 5 months ago

Also, I can't get file links working in sql. On top of that the tokens only work part of the time. Do you think that's an issue with the IDE or the plugin? [cid:9e7069b5-d6df-40b4-aaf5-a261145b6938]

Sean McCown (817)937-6154 [cid:2d038ea8-6459-451e-8c41-b861b959447f]

From: Igor Zarvanskyi @.> Sent: Wednesday, January 17, 2024 09:35 To: clutcher/bh @.> Cc: Sean McCown @.>; Mention @.> Subject: Re: [clutcher/bh] Add referencing of methods/functions in non OOP languages (Issue #92)

@MinionWarehttps://github.com/MinionWare

— Reply to this email directly, view it on GitHubhttps://github.com/clutcher/bh/issues/92#issuecomment-1896180511, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADY75MYM7C43Q6XWBRKUN5LYO74VTAVCNFSM6AAAAABBGOIA6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJWGE4DANJRGE. You are receiving this because you were mentioned.Message ID: @.***>

clutcher commented 5 months ago

@MinionWare Will add display of tagged comment on Ctrl+hover and Quick Documentation.

Can you provide tokens, which are not working, screenshots etc? Need more information on your exact case, as my sample test cases works without issues.

clutcher commented 5 months ago

@MinionWare I added dislaying of tagged comments on hover/quick doc in version 2024.1.2.

As for your issues with highlight - can you provide more details?