clutchski / coffeelint

Lint your CoffeeScript.
http://www.coffeelint.org
Other
1.18k stars 171 forks source link

Make tests pass with latest master of CoffeeScript #567

Closed lydell closed 8 years ago

lydell commented 8 years ago

Tested with jashkenas/coffeescript commit d7e752b.

They also still pass with latest stable CoffeeScript (1.10.0).

  1. Run npm test as usual to verify that it works with CoffeeScript 0.10.0.
  2. Install latest master of CoffeeScript and run npm test.

NOTE: The most common change in this PR is adding checks for the new 'PROPERTY' around code that looks for the 'IDENTIFIER' token. There are more occurances of 'IDENTIFIER' in the code that I have NOT touched. I simply worked until all tests passed. I'm not sure if these cases need modifying or not. If they do, the tests need to be updated to cover it. I'd like some help from a more experienced coffeelint developer here.

swang commented 8 years ago

Hey thanks for doing this. Looks like the tests didn't pass because of the length limit, but that seems trivial to fix.

When did this property token get added? Would like to take a look at the CoffeeScript to see what changed. It looks like you got the tests passing regardless.

lydell commented 8 years ago

npm test failed for me even before I started working on this, because of lint errors, but the test suite passed. I don't think I've introduced any new lint errors.

swang commented 8 years ago

Merged into a5babd23aa094132c0bdf97d47e639650aec72a5

lydell commented 8 years ago

Thanks! :+1: