search

clutchski / coffeelint

Lint your CoffeeScript.
http://www.coffeelint.org
Other
1.17k stars 172 forks source link

Allow any CoffeeScript version above 2.0.0 #622

Closed boris-petrov closed 6 years ago

boris-petrov commented 6 years ago

CoffeeScript has newer versions with fixes and features, so CoffeeLint should not fix the version used.

swang commented 6 years ago

Hi. Thanks for the pull request!

The reason why I decided to pin to specific versions was so I don't bring in changes that coffeescript has made between minor/patch releases. They don't seem to follow semver much, so I can't expect any minor or patch release to be compatible (this might have change since there are now new maintainers).

Also the part of coffeescript that we actually need, the lexer, goes through different changes internally that affects us. So I'd rather pin to specific versions than to use a caret/tilde range.

Feel free to make it so it pins to the latest version and then (assuming that doesn't cause an issue) I'll gladly merge it.

boris-petrov commented 6 years ago

@swang - thanks for the answer. The problem with pinning is that you can't update CoffeeLint all the time and make new versions for every single simple patch that CoffeeScript does to fix something small. And when you've pinned the version, this means that all users of CoffeeLint will use that specific version and cannot override it even if newer CoffeeScript versions works fine.

E.g. right now I'm waiting for them to fix something that I reported yesterday and when they fix it and release a new version (hopefully in the next few days) I won't be able to use it.

I think they do follow semantic versioning so that probably shouldn't be a concern of yours. Anyway, you could at least fix it to a specific major revision and leave at least the minor to be changeable (I think this was done with a ~ in package.json) so we could benefit from bugfixes. If something breaks, you can always revert to using a fixed version. And you would need to update CoffeeLint only when 2.1, 2.2, etc come out.

P.S. I've updated the pull request to use a ~ if you decide that I'm right. :)

boris-petrov commented 6 years ago

@swang - ping? :) CoffeeScript 2.0.2 is out and I would like to use the fixes from there. :)

swang commented 6 years ago

I set semver to ~2.0.x and published 2.0.7

boris-petrov commented 6 years ago

Thanks!