Closed jacksonrayhamilton closed 4 years ago
Hi @swang, any chance we can work together to get this merged and backported? Just let me know, thanks.
@jacksonrayhamilton further development on coffeelint will happen on https://github.com/coffeelint/coffeelint as @coffeelint/cli
If you need to use coffeelint@1 your best bet is to fork it into your own npm package.
This will be added to @coffeelint/cli in https://github.com/coffeelint/coffeelint/pull/12. Thanks!
@UziTech would you be willing to do a 1.x release with this change in it under your package name @coffeelint/cli
?
It would be easiest for you to just fork it and create your own package on npm.
There is a lot to do to get 2.x up to date so I won't have time to release a 1.x anytime soon.
If you’re willing to add me as a collaborator on the GitHub repo and even the NPM org, I could help with releasing a 1.6.3 patch release.
I invited you to the GitHub organization. What is your npm username so I can send the invite for the organization?
Thanks, it’s jacksonrayhamilton on npm as well.
I sent the invites. Welcome aboard 😀🎉✨
Migrating this to https://github.com/coffeelint/coffeelint/pull/42.
This fix is now available via:
yarn global add @coffeelint/cli@1
Or:
npm i -g @coffeelint/cli@1
Hello,
I noticed that the “; context: …” string printed by the
checkstyle
reporter might not list a context, which can make the error messages look awkward.e.g., error messages like this will be printed:
Is there a reason “; context: ” is always printed there? It made me think that the tool was broken at first.
Assuming that string isn’t serving a purpose when it’s blank, this PR removes it in that case.
Also, can this please be backported to
coffeelint@1
and published under1.16.3
branched from the last@1
release? Our projects still use CoffeeScript 1 andcoffeelint@2
seems to have a rough time with our files because of that, so I would need the change deployed on version 1 in order to use it via the usual NPM channel.Thanks, Jackson