search

clux / modul8

NO LONGER MAINTAINED - browserify is too similar and is better (see issues)
http://clux.github.com/modul8
MIT License
22 stars 4 forks source link

dependency resolver issue #14

Closed panosru closed 12 years ago

panosru commented 12 years ago

Hi, I try to use gravatar module with modul8 but when I run my application I get Error: modul8 resolver could not load npm module gravatarpackage.json lies about main: index does not exist I'm not sure if it is gravatar's issue because I don't see anything strange there... I use gravatar = require 'npm::gravatar' in coffee script.

Thanks

clux commented 12 years ago

Yeah, I can see what's going on here.

Gravatar is using package.json with main set to 'index' Usually, when people specify main, they specify with an extension. I could possibly be more lax with what I accept from there.

Simple solution for now should be just appending .js to the package.json's main.

panosru commented 12 years ago

@clux Hello, thanks for the reply, I will do a pull request on gravatar because I think it's not modul8 that need to be more lax about that, I believe package.json's main property should reflect the filename along with it's extension.

Thanks

clux commented 12 years ago

Yeah, they might be in the wrong, but to be fair, I allow this kind of requiring elsewhere. I might as well be consistent. It's a two line fix for me anyway. Will include in the next version.

panosru commented 12 years ago

@clux Cool, but either way they will merge my pull request today ;)

emerleite commented 12 years ago

Just released gravatar version 1.0.6 with the fix. Thanks guys.

panosru commented 12 years ago

:)