clux / modul8

NO LONGER MAINTAINED - browserify is too similar and is better (see issues)
http://clux.github.com/modul8
MIT License
22 stars 4 forks source link

Using `path` to fully support windows #9

Open Raynos opened 12 years ago

Raynos commented 12 years ago

Code like ref

reqStr[0...2] is './' or reqStr[0...3] is '../'

will break in windows because of / vs \\.

One should favor using methods from path like path.relative

clux commented 12 years ago

Ah, yes, I remember thinking about that ages ago, then forgot. Thanks, will have a look at that again this weekend.

clux commented 12 years ago

Several path functions are very useful and have allowed me to cut down much of my own resolving code!

However, by introducing windows resolvability on the server, they will still fail on the client. There are 2 (good) ways in which this can be solved that I see:

Currently undecided on what is the best way to proceed.

Raynos commented 12 years ago

path has already been forked for the client by SubStack

clux commented 12 years ago

substack's fork is posix only. I might take the win32 bits from node and include it/posix version conditionally. I'm not sure whether posix and windows slashes can coexist in the same codebase yet though. Surely they must, as npm modules are mostly posix, but if windows code use other slashes, and path determines slashtype by checking process.platform === 'win32', I am curious how anything will work at windows at all.

Anyway, been a bit busy over xmas, but things are making progress again.

clux commented 12 years ago

Using substack's posix fork now. Can write a w32 version and include it conditionally. But due to above reasons, not sure how to proceed yet, so I'm putting it on hold for 0.15.0