search

clux / muslrust

Docker environment for building musl based static linux rust binaries
MIT License
965 stars 88 forks source link

Pin Rustup's version #63

Closed AzureMarker closed 5 years ago

AzureMarker commented 5 years ago

Version updates of rustup can have negative effects on the image, not to mention the reproducibility of the docker container. For one such example of a negative effect, see #62.

clux commented 5 years ago

Thank you. That makes sense from a reproducibility standpoint, but it's going to be another thing I manually have to bump. Is it possible to find the current latest version somewhere? That way we can stash the mechanism for updating the version inside the update_libs.py.

AzureMarker commented 5 years ago

That's a good idea. From looking at the self-update code, you can find the latest version at https://static.rust-lang.org/rustup/release-stable.toml. I'll look into adding that to the update_libs.py script.

AzureMarker commented 5 years ago

@clux Do you want to use the version of rustup in the AUR or the upstream version?

AzureMarker commented 5 years ago

I've added the Rustup update functionality into update_libs.py, though it adds a dependency on toml for parsing Rustup's version config. Is this ok?

clux commented 5 years ago

Yeah, absolutely. Happy to merge this. Just one question on the Dockerfile.

AzureMarker commented 5 years ago

Re-triggering Travis as it may have run into a temporary error.

clux commented 5 years ago

Yeah, not sure what's up with master atm. Your README change clearly didn't break things :thinking:

AzureMarker commented 5 years ago

I just ran though the Travis script locally on master and didn't have any issues. Maybe debugging it would help shed some light?

This could also be related to a recent change on Travis: https://changelog.travis-ci.com/xenial-and-cache-support-added-for-arm-builds-123563

AzureMarker commented 5 years ago

@clux Please let me know if I can do anything further to help find the current CI issue.

clux commented 5 years ago

So, yesterday, I had a look to see if I could trigger debug builds, and it took me into a different travis interface that required payment, but then ultimately got distracted. Good news seems to be that the ephemeral travis issue fixed itself. :man_shrugging: