Move to action model (using services and topics to emulate actions)

clydemcqueen / tello_ros

C++ ROS2 driver for DJI Tello drones

BSD 3-Clause "New" or "Revised" License

194 stars 65 forks source link

Closed clydemcqueen closed 5 years ago

clydemcqueen commented 5 years ago

Refactored the threading model as well, and cleaned up the logic.

You can test this w/ LOCAL_EMULATION (run driver and emulator nodes).

You can also test this with a drone using the ros2 service CLI.

I'm working on the flock2 refactor, which might lead to a few more commits. Please hold off on the merge.

ptrmu commented 5 years ago

I am not able to try this out for a few days. I scanned the code and it looks excellent as usual. So I am just going to merge the pull request now,

ptrmu commented 5 years ago

I will leave the branch around incase you have checked it out for integration with flock2.