search

clyveycui / pe

0 stars 0 forks source link

Find by level of education is confusing #9

Open clyveycui opened 2 years ago

clyveycui commented 2 years ago

None of the levels of education start with school, but "find l/high school" works, but "find l/school" doesn't work

nus-pe-bot commented 2 years ago

Team's Response

Indeed how you described is how we intend for the application to work. "find l/high school" works as "high school" is a valid level of education, hence, you can use that search term. However, "find l/school" does not work amongst all the valid level of education, none of them start with "school", henceforth you cannot use that as a search term itself.

This is a design consideration made so that we can ensure that the user is able to find specific levels of education.

It works as described in the UG.

image.png

For example, if we allow l/school to work, then l/High school will also return both Middle School and High School since both contain the word school. As such, we have decided to only match levels of education by starting words to ensure specificity of searching and search results for the user.

Moreover, we disagree with the severity of this issue and think it should be a low as regardless of this, the application works just fine and if the UG was read clearly, this would not be even an issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hi, thank you for the explanation, but it is still rather unclear for me.

image.png

The last point mentions that if the none of levels of education starts with bob, so it is invalid. This suggests if there is any search keyword that is invalid, then the search should fail.

image.png

As seen above, any keywords used in the search must be the starting word of at least one of Level of education.

image.png

As shown above, the exhaustive list of Level of education that the app currently supports is here. There is no level of education that starts with School. The documentation itself is self contradictory as based on explanation, "school" should be a valid keyword.

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: This feels more like failed validation of the level of education keyword rather than an improvement that could be made to the app.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]