search

cmaas / markdown-it-table-of-contents

A table of contents plugin for Markdown-it
MIT License
99 stars 33 forks source link

Interested in maintaining package #53

Closed cpadilla closed 3 years ago

cpadilla commented 3 years ago

I'd be interested maintaining this package. I started my blog recently using Vuepress and GitHub pages, which I've been publishing to pretty consistently.

After comparing this package (which seems to be included with Vuepress by default) with the alternative, vuepress-plugin-table-of-contents, I decided I preferred this package's TOC because it's strictly markdown and it doesn't require me to customize a Vue component.

I've opened PR #52 as one of my first open-source contributions, which I think is significant considering how long I've been using GitHub for. Between that and PR #51, the two issues I had with this package have been fixed, so I'd be happy to maintain it moving forward. :)

martinlissmyr commented 3 years ago

Cool. Sounds good to me.

Two things need to be done:

  1. Transfer ownership of repo
  2. Transfer ownership of npm package

Do you have a user on npmjs? if so, what's your username?

cpadilla commented 3 years ago

Yes, my username is rockzombie2 on there

martinlissmyr commented 3 years ago

You are now invited as a maintainer on Npm. Please confirm that you can access the package and then I will remove myself.

Before I can transfer the Github repo to you you have to remove your local branch. Github says the repo already exists otherwise. Please let me know when it's done and then I will finalise everything.

cpadilla commented 3 years ago

Okay, I can see I have access to the package on Npm and I deleted my fork of the repo on Github.

martinlissmyr commented 3 years ago

Ok, then I'll start the transfer. Hold on. :)

martinlissmyr commented 3 years ago

There we go. After you've accepted I'll remove myself from the NPM package and it's all yours!

cpadilla commented 3 years ago

Looks like the github invitation expired. Can you send it again?

martinlissmyr commented 3 years ago

Ok, check now.

cpadilla commented 3 years ago

Yep, looks good! Thanks for facilitating the transfer. I guess unless there's anything else that needs to be taken care of, we can wrap up this issue.

martinlissmyr commented 3 years ago

Yep. Thanks and good luck!

martinlissmyr commented 3 years ago

Oh, you should probably fix the references in the package.json and do a release so that NPM points to the right place.

cpadilla commented 3 years ago

Thanks, will do.