search

cmachler / aws-lambda-ebs-backups

Python scripts to be run using AWS's Lambda service to Backup and Delete Snapshots of EBS Volumes
MIT License
31 stars 21 forks source link

small issue with Name taging #1

Closed pasea closed 7 years ago

pasea commented 7 years ago

I noticed if you use this to make backup of multiple volumes, it adds same mount point name for all backups. For example if first volume it takes snapshots is /dev/xvda all others will have same in the Name field.

        ec.create_tags(
            Resources=to_tag[retention_days],
            Tags=[
                {'Key': 'Name', 'Value': dev_attachment}
cmachler commented 7 years ago

Good catch, never tested instances with multiple volumes. Will take a look at it when I have free time.

cmachler commented 7 years ago

@pasea try now, I created a separate collection for creating mount point tags.

pasea commented 7 years ago

Works like a charm. Thank you.