search

cmackay / google-analytics-plugin

Cordova Google Analytics Plugin for Android & iOS
Apache License 2.0
89 stars 43 forks source link

Separate tag manager on the plugin API #25

Closed zmagyar closed 9 years ago

zmagyar commented 9 years ago

Suggested API change

cmackay commented 9 years ago

Hi Zoltan,

Thanks for the PR. I appreciate all the tag manager functions you have added. I think maybe the best approach now is to take a look if there are any additional ios features you would like to get into an initial release of this. When you feel that it is a good set of tag manager features for the first release let me know. Then what I will do is wrap up any android integration and then review and update the js API. I like the approach you have implemented. One thing I want to do is make it kind of similar to the android api since that is based on the play services which seems to be the direction things are heading for the google mobile services. Once you feel the iOS features are at a good point let me know. I think it provides a good set of initial tag manager features but I am not sure if you had anything else in mind. Thanks again for all your contributions for this!

-Craig