search

cmackay / google-analytics-plugin

Cordova Google Analytics Plugin for Android & iOS
Apache License 2.0
89 stars 43 forks source link

Thread pooling is needed for Android #27

Closed ishaigor closed 9 years ago

ishaigor commented 9 years ago

Hi Craig

Noticed the following suggestion in the android logs: W/PluginManager( 3186): THREAD WARNING: exec() call to GoogleAnalytics.send blocked the main thread for 29ms. Plugin should use CordovaInterface.getThreadPool().

Can this be incorporated?

Thanks, Irena

cmackay commented 9 years ago

Hi Irena,

Thanks for the message. I will look into getting this added to the plugin.

Thanks,

-Craig

cmackay commented 9 years ago

Hi Irena,

I found the following which looks like a good example of the usage of getThreadPool. I will try to get these changes into a new release within the new couple days.

https://github.com/kryptosmobile/phonegap-parse-plugin/blob/master/src/android/ParsePlugin.java

Thanks,

-Craig

cmackay commented 9 years ago

Hi Irena,

I just pushed a release that includes the threadpool support for Android. Let me know if you have any additional feedback or issues.

Thanks,

-Craig