search

cmackay / google-analytics-plugin

Cordova Google Analytics Plugin for Android & iOS
Apache License 2.0
89 stars 43 forks source link

App installs #76

Open hirbod opened 7 years ago

hirbod commented 7 years ago

Hi,

are app installs supported?

https://support.google.com/analytics/answer/3389142?hl=en

cmackay commented 7 years ago

Hi @Hirbod,

Currently install tracking is not supported. I would consider adding it to the plugin if I didn't feel that it might impact other users. It requires manifest changes in Android which would have to be applied for all users of the plugin. I am not sure if there is a way to conditionally enable parts of the manifest within a cordova plugin. If we enable it for all users, I don't know if there is any issues in doing so. There might not be. But a bigger problem is on the iOS side. This feature requires libAdIdAccess which has been known to cause app store submissions to fail in the past when this was enabled. There is additional info in the issues related to this: https://github.com/cmackay/google-analytics-plugin/search?q=libAdIdAccess&type=Issues&utf8=%E2%9C%93

If there are ways to address these concerns, I would consider enabling this feature but I am not sure that there is a solution for this. Thanks for your message.

-Craig

hirbod commented 7 years ago

Hi @cmackay thanks for your response. It should prob. be possible with something like a variable or hook? --variable INSTALLTRACKING="true". I'm not really a plugin-api-pro, but I guess it should be possible this way.

I am already using AdID, and it's not a big deal at all, as long you toggle the correct checkboxes at submit-progress.

cmackay commented 7 years ago

I would recommend forking the project if you want to add this. I am not adding libAdIdAccess due to issues it has caused in the past.

hirbod commented 7 years ago

Managing and keeping a fork is pretty time intensive. I would like to figure out if there is any way to include a condition which doesn't interfere with other users setup. (your point is totally clear to me)

cmackay commented 7 years ago

If you find a good solution that will not impact other users and you are willing to help in supporting users as a result of your changes, I welcome a pull request. I just don't want to get caught up in supporting app store rejection issues again. :) Thanks!