search

cmaclell / concept_formation

Python implementations of TRESTLE, COBWEB/3, and COBWEB
MIT License
61 stars 18 forks source link

Is attr_val_guess_gain properly handling None probabilities? #31

Closed cmaclell closed 5 years ago

cmaclell commented 7 years ago

I'm not sure, I suspect what we have works, but isn't 100% correct.

eharpste commented 7 years ago

@cmaclell thinks this one might be solved but double check.

cmaclell commented 5 years ago

I believe we're good going to close this issue. I can't remember the exact changes made here, but it loos like we no longer use attr_value_guess_gain. Now we just copy the node, add the instance, then compute the expected correct guesses. My guess is that we did this to avoid exactly this issue of missing values being handled properly.

Also, based on this discussion I added #78 to explore multiple ways to handle missing values.