search

cmaclell / concept_formation

Python implementations of TRESTLE, COBWEB/3, and COBWEB
MIT License
61 stars 18 forks source link

Consider modifying visualize_cluster to do the clustering for you. #49

Closed cmaclell closed 7 years ago

cmaclell commented 7 years ago

I'm not sure exactly what this would look like, but it would be nice if we could do something like, visualize_cluster(tree, instances, criterion="BIC") and it would generate the tree for you, without you having to know how do use the clustering stuff.

eharpste commented 7 years ago

I was hesitant to do this because there are a bunch of parameters to the clustering functions that would be duplicated, (e.g., criterion, number of splits, and modifying or not). My vote would be to make the documentation for the function clearer and link to the cluster module itself. I'm not sure what it would look like to put a doctest in there or make an example of how to use it given how it generates the html but that might also help.