Closed montchr closed 2 years ago
Even if this change fixes the install step, I think the patches also need updating. But that'd probably be best addressed in a new ticket/PR.
Also, see https://github.com/sagittaros/emacs-osx/issues/5 – looks like they're running into a similar or identical issue with patches.
https://github.com/montchr/emacs/runs/4659428174?check_suite_focus=true
emacs> patching sources
emacs> applying patch /nix/store/j9fa4phwrah4rwg3va7whlxljf8qbxba-fix-window-role.patch
emacs> patching file src/nsterm.m
emacs> Hunk #1 succeeded at 8619 (offset -259 lines).
emacs> applying patch /nix/store/nlgq5vra3c0r1snj0wbmd49r78pagi5j-no-titlebar.patch
emacs> patching file src/nsterm.m
emacs> Hunk #1 FAILED at 433.
emacs> Hunk #2 succeeded at 8347 (offset 42 lines).
emacs> 1 out of 2 hunks FAILED -- saving rejects to file src/nsterm.m.rej
error: builder for '/nix/store/4fi1q2cx2j06zbxh2x10bdgphn3q6700-emacs-29.0.50.drv' failed with exit code 1;
last 10 log lines:
> source root is source
> patching sources
> applying patch /nix/store/j9fa4phwrah4rwg3va7whlxljf8qbxba-fix-window-role.patch
> patching file src/nsterm.m
> Hunk #1 succeeded at 8619 (offset -259 lines).
> applying patch /nix/store/nlgq5vra3c0r1snj0wbmd49r78pagi5j-no-titlebar.patch
> patching file src/nsterm.m
> Hunk #1 FAILED at 433.
> Hunk #2 succeeded at 8347 (offset 42 lines).
> 1 out of 2 hunks FAILED -- saving rejects to file src/nsterm.m.rej
For full logs, run 'nix log /nix/store/4fi1q2cx2j06zbxh2x10bdgphn3q6700-emacs-29.0.50.drv'.
Error: Process completed with exit code 1.
Thanks for this! Yeah, I've been on hiatus for a while, dealing with real-life-things :)
I'll merge it for now and look at fixing forward on master for the patching issue 👍
I noticed the automated builds have been failing for quite a while now, about 23 days.
https://github.com/cmacrae/emacs/actions/runs/1547228221
This run appears to be the first automated run that failed, and each automated run since has failed. Looks like it's getting stuck on some issue during the
install-nix-action
step. In my fork, I've seen similar errors, and I believe they went away when I updated to the latest version of theinstall-nix-action
.Here's the full error from the latest run: