search

cmaija / ParkHangs

CPSC 436i Group Project
1 stars 1 forks source link

Implement Google sign in to app. Implement user profile, favourite pa… #50

Closed gordonzhang17 closed 4 years ago

gordonzhang17 commented 4 years ago

There's a million changes. Please let me know if there's anything! In order for this to work, npm install and also include the following in your web app .env file: REACT_APP_GOOGLE_API_CLIENT_ID='LOOK AT THE GOOGLE API ACCOUNT FOR THE CLIENT ID'

cmaija commented 4 years ago

looks mostly fine, just wondering if you're planning on finishing implementing all the success/error actions in the user slice

also dude your ide's whitespace linter is killing me omg

gordonzhang17 commented 4 years ago

looks mostly fine, just wondering if you're planning on finishing implementing all the success/error actions in the user slice

also dude your ide's whitespace linter is killing me omg

lolol yeah I noticed. I made a new changes if that helps. And I can later on for the success/error actions

cmaija commented 4 years ago

sorry, my merge caused some little conflicts that I just resolved

gordonzhang17 commented 4 years ago

styling should have it's own css file, and are the remaining TODOs just forgotten and fixed, or still experiencing issues

the remaining todos are just cases for errors. Could work on them or not.