search

cmajor-lang / cmajor

The Cmajor public repository
https://cmajor.dev
Other
522 stars 31 forks source link

ONNX != OnnxRuntime #34

Closed olilarkin closed 6 months ago

olilarkin commented 6 months ago

Noticed a mistake in the docs here:

https://github.com/cmajor-lang/cmajor/blob/e94e46d4cbc9d1f18d534e2952e2ddc728c8dcb8/docs/Cmaj%20Inference.md?plain=1#L5C1-L6C1

julianstorer commented 6 months ago

OK.. this is quite nuanced, but your point is that it's not correct to refer to ONNX as an engine, but as a format?

olilarkin commented 6 months ago

Yes, It’s a bit of a nitpick. onnx is the name of the interchange format developed by a bunch of different people, onnx runtime is the engine developed by Microsoft

On Mon, 4 Mar 2024 at 15:00, Julian Storer @.***> wrote:

OK.. this is quite nuanced, but your point is that it's not correct to refer to ONNX as an engine, but as a format?

— Reply to this email directly, view it on GitHub https://github.com/cmajor-lang/cmajor/issues/34#issuecomment-1976644993, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFACLXOJ2W2KMQFKUSWQCLYWR5BTAVCNFSM6AAAAABEFFKGUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZWGY2DIOJZGM . You are receiving this because you authored the thread.Message ID: @.***>

julianstorer commented 6 months ago

OK ta, will clarify..