search

cmajor-lang / cmajor

The Cmajor public repository
https://cmajor.dev
Other
534 stars 31 forks source link

Returning loadPatch value from JUCEPluginBase #48

Closed remaininlight closed 2 months ago

remaininlight commented 7 months ago

The return value of Patch::loadPatch (https://github.com/cmajor-lang/cmajor/blob/main/include/cmajor/helpers/cmaj_Patch.h#L1914) is a boolean indicating whether the patch is playable or not

This return value would be useful for code using the JUCEPluginBase but is currently swallowed in JUCEPluginBase::loadPatch (https://github.com/cmajor-lang/cmajor/blob/main/include/cmajor/helpers/cmaj_JUCEPlugin.h#L117), which returns void

This PR forwards the value from the Patch out through the Plugin method

cesaref commented 2 months ago

I believe the updated version of this header includes exposing the bool result, so this has been resolved