search

cmake-basis / legacy

Legacy CMake BASIS project for versions 3.2 and older. For newer versions, go to
https://github.com/cmake-basis/BASIS
Other
13 stars 11 forks source link

Bootstrapping function should make BASIS_INSTALL_PREFIX advanced #502

Closed schuhschuh closed 8 years ago

schuhschuh commented 8 years ago

After the second run, when the user decided not to set the BASIS_INSTALL_PREFIX, it should probably be declared as advanced option.

ahundt commented 8 years ago

Are you sure about that one? Benefits seem minimal, but it is not really a big deal either way.

schuhschuh commented 8 years ago

It's just a small change. I just would like to hide any (possibly unused/unwanted) BASIS related variables from those seen by users of a project. Of course developers could mark it advanced in their root CMakeLists.txt or Settings.cmake files themselves.

On Sun, 27 Dec 2015 6:21 am Andrew Hundt notifications@github.com wrote:

Are you sure about that one? Benefits seem minimal, but it is not really a big deal either way.

— Reply to this email directly or view it on GitHub https://github.com/schuhschuh/cmake-basis/issues/502#issuecomment-167388623 .

ahundt commented 8 years ago

makes sense