basis_export_targets, basis_get_target_uid do not use BASIS_NAMESPACE_DELIMITER_CMAKE

cmake-basis / legacy

Legacy CMake BASIS project for versions 3.2 and older. For newer versions, go to

https://github.com/cmake-basis/BASIS

Other

13 stars 11 forks source link

basis_export_targets, basis_get_target_uid do not use BASIS_NAMESPACE_DELIMITER_CMAKE #546

Closed schuhschuh closed 8 years ago

schuhschuh commented 8 years ago

It always uses a dot (.) as namespace separator. Modern CMake, however, has chosen Perl-style :: instead. Would be good if users can set the BASIS_NAMESPACE_DELIMITER_CMAKE to the separator of their choice, which should now default to ::.

Seems this variable is not used by any of the namespaced target functions. Need to see again what it was good for...

schuhschuh commented 8 years ago

The namespace delimiters are used in basis_initialize_settings.

schuhschuh commented 8 years ago

It is indeed a bug that BASIS_NAMESPACE_DELIMITER_CMAKE is not used in basis_get_target_uid and related functions.