search

cmallwitz / Financials-Extension

Extension for LibreOffice Calc to access stock market data
Other
151 stars 21 forks source link

Ignore spans with None text #70

Closed beckjake closed 1 year ago

beckjake commented 1 year ago

Thanks for all your work on this great extension! 3.2.0 fixed most of my problems with the latest yahoo update, but some tickers (FZILX and FZROX, I assume some others) aren't accessible and raise an exception. It appears that now some spans have a text attribute that's None in this loop. Ignoring them fixed =GETREALTIME("FZILX", 21, "YAHOO") for me.

cmallwitz commented 1 year ago

Thanks for your feedback - usually PRs are always welcome!

I hope if you don't mind if this one doesn't get merged though. I'm about to prepare a new version 3.2.1 fixing a few more of these edge cases where the code should be more careful before using retrieved values. This will address the specific issue you are trying to fix with this PR too.

beckjake commented 1 year ago

Sounds great to me!

cmallwitz commented 1 year ago

I just pushed release version 3.2.1 fixing a few outstanding issues. Have a look and let me know if I missed anything!