Closed KonstantinSchubert closed 7 years ago
Merging #17 into master will decrease coverage by
6.37%
. The diff coverage is48%
.
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 87.39% 81.02% -6.38%
==========================================
Files 1 1
Lines 119 137 +18
Branches 14 18 +4
==========================================
+ Hits 104 111 +7
- Misses 13 22 +9
- Partials 2 4 +2
Impacted Files | Coverage Δ | |
---|---|---|
cmreslogging/handlers.py | 81.02% <48%> (-6.38%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f047106...a003df6. Read the comment docs.
Thanks for all this changes @KonstantinSchubert !
( This builds upon my previous pull request that adds AWS elasticsearch logging, so I guess it should be reviewed afterwards. )
Instead of scheduling the flush "recursively", with this pull request, a flush will be scheduled under two conditions:
This has two advantages:
__init__
is called, the logging handler is copied into each process. Before, it would flush the buffer only in the original process and not log in any forked processes. Now, it will be logging in all processes. I noticed that I needed this for example for django_q.