search

cmanaha / python-elasticsearch-logger

Python Elasticsearch handler for the standard python logging framework
Other
232 stars 116 forks source link

Missing log record fields: asctime and message in ElasticSearch #24

Closed aldbr closed 7 years ago

aldbr commented 7 years ago

Hello,

Due to the missing format method call in the emit handler method, the log record is not formatted if we use your handler as first handler. This implies that the asctime and the message fields are not created and can not be available in ElasticSearch. Is it your choice to improve the performances or just a bug ?

If it is a bug, I can make a pull request or just complete the current in order to solve the issue. Thank you in advance

cmanaha commented 7 years ago

I'm happy to take pull requests; actually I'm happy to give others admin access to the project for the times where I might not be available to merge, test and produce/push a release.

Saludos - Cheers Carlos

On 7 Jul 2017, at 16:11, aldbr notifications@github.com wrote:

Hello,

Due to the missing format method call in the emit handler method, the log record is not formatted if we use your handler as first handler. This implies that the asctime and the message fields are not created and can not be available in ElasticSearch. Is it your choice to improve the performances or just a bug ?

If it is a bug, I can make a pull request or just complete the current in order to solve the issue. Thank you in advance

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

aldbr commented 7 years ago

I would be happy to help the project if you want to give me an admin access.

Cheers

cmanaha commented 7 years ago

Just added 3 of you as collaborators ( as you have posted all good PR's ); I'm sorry that I don't have much time this days to keep up with with this in a timely way.