search

cmanaha / python-elasticsearch-logger

Python Elasticsearch handler for the standard python logging framework
Other
232 stars 116 forks source link

Simplify CMRESSerializer code #30

Closed KonstantinSchubert closed 7 years ago

KonstantinSchubert commented 7 years ago

By calling into super, we can avoid duplicating code from elasticsearch.

codecov-io commented 7 years ago

Codecov Report

Merging #30 into master will decrease coverage by 0.55%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   83.33%   82.78%   -0.56%     
==========================================
  Files           2        2              
  Lines         156      151       -5     
  Branches       20       18       -2     
==========================================
- Hits          130      125       -5     
  Misses         22       22              
  Partials        4        4
Impacted Files Coverage Δ
cmreslogging/serializers.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b8bbee...8820ce1. Read the comment docs.

KonstantinSchubert commented 7 years ago

This is funny. I basically just remove code, but the coverage goes down.... I imagine this happens because the code I removed was considered to be "covered". :)

cmanaha commented 7 years ago

Spot on with your coverage assumption. Will be merging and releasing over the weekend if there are no other objections. Time also to remove the beta from the package description as well.

KonstantinSchubert commented 7 years ago

Thanks!

KonstantinSchubert commented 7 years ago

bump...

KonstantinSchubert commented 7 years ago

Hey, can we merge this?

If you still have questions or concerns about this PR, I will of course address them.

cmanaha commented 7 years ago

No, that's fine thanks Konstantin.

cmanaha commented 7 years ago

After testing and merging your changes, I've done an upload of version 1.0.0 to pypi repositories