Open kusha opened 6 years ago
As a user, I am very interested in your fork.
Have you added to it testing cases and coverage to it ? Was there any reason in particular to deviate so much from the original implementation ? I guess that just reading the code and checking with the tests you have should give all the evidence on why to change the implementation.
As for merging. I'd suggest keeping it simple. If your tests/coverage and the implementation show's thats a better approach, I'd rather prefer to consolidate into one solution (your solution) that works well in both cases. There is no need for duplication or extra complexity...
Hi,
I'm using your logger in my application. I've made some changes (modified inherited CMRESHandler class):
I can prepare a pull request, and leave it as another class (not everyone needs those features). Are you interested in?