cmanaha / python-elasticsearch-logger

Python Elasticsearch handler for the standard python logging framework
Other
232 stars 116 forks source link

Logger is not lazy, but CMRESHandler is #74

Open Aethylred opened 4 years ago

Aethylred commented 4 years ago

Pylint now warns that "Logger is not lazy" when you use % to do string formatting, meaning you just pass the strings and replacements directly rather than % (list, of, things, being, replaced)

However, CMRESHandler is lazy and just passes these on as arguments so when logger us used to log to file you see:

Completed provisioning 0 of 1077 directories for 0 of 0 users in 0:04:51.466437

But in elastic search you see:

msg:Completed provisioning %s of %s directories for %s of %s users  in %s args:0, 1077, 0, 0, 0:04:51.466437