Remove the declaring the type as it is deprecated

cmanaha / python-elasticsearch-logger

Python Elasticsearch handler for the standard python logging framework

Other

232 stars 115 forks source link

Remove the declaring the type as it is deprecated #79

Open werebear73 opened 3 years ago

werebear73 commented 3 years ago

This is resolve #76 (Specifying types in bulk requests is deprecated) which results in the following warning.

ElasticsearchDeprecationWarning: [types removal] Specifying types in bulk requests is deprecated.

werebear73 commented 3 years ago

@cmanaha are there any comments or needs to get this pull request accepted?

javiermatos commented 3 years ago

Would be great to have this merged. This change works for me.

simonjk commented 3 years ago

+1 would be great to have those issue resolved

martinschi commented 3 years ago

Can we get this merged, please?

werebear73 commented 3 years ago

Has anyone heard from the project leader?

drumadrian commented 3 years ago

Hey @werebear73

The original author (Carlos) and I talked a few weeks ago and he gave me the permissions to help bring the code and package up to date for everyone.

Can we setup a meeting this week to review your merge request again? 🤓

Adrian

werebear73 commented 3 years ago

Sure

drumadrian commented 3 years ago

How about tomorrow at 8am PDT for you and anyone else that wants to chat?

8pm PDT or during the workday is good for me too.

If tomorrow works we can use this Chime meeting info:

You have been invited to an online meeting, powered by Amazon Chime.

Click to join the meeting: https://chime.aws/2764064532
Meeting ID: 2764 06 4532
A headset is recommended or you may use your computer’s microphone and speakers.

Call in using your phone:
United States Toll-Free (1): +1 855-552-4463
Meeting ID: 2764 06 4532
One-click Mobile Dial-in (United States (1)): +1 206-462-5569,,,2764064532#
United States (1): +1 206-462-5569
International: https://chime.aws/dialinnumbers/
Dial-in attendees must enter *7 to mute or unmute themselves.

Download Amazon Chime at https://aws.amazon.com/chime/download
For information about creating an Amazon Chime account, see https://aws.amazon.com/chime/getting-started

martinschi commented 3 years ago

The real question is whether it makes sense to try to fix this project when there's ECS-compliant alternative which seems to be maintained: https://github.com/IMInterne/python-elasticsearch-ecs-logger. I moved all my projects to it and it was mostly plug-and-play replacement and besides following ECS schema it also fixed quite a few bugs on the way, including some log messages getting lost on their way to Elasticsearch.

werebear73 commented 3 years ago

Reopened after decision with Adrian

elijahxb commented 2 years ago

Maybe, we could solve this problem by passing a None value to type field es_doc_type just like this: CMRESHandler(xxx=xxx, es_doc_type=None)