[TBC] Disciple of Naralex misbehavior

[thrd92]

Current behavior: Disciple of Naralex becomes neutral to players during the event (no more friendly), and he becomes attackable when he's entering combat, also he's ignoring the mobs (uncleared trash) on his way (no aggro).

Expected behavior: Disciple of Naralex should be friendly https://youtu.be/dVdUzMpLvoM?t=1182

Steps to reproduce:

1. Kill the required bosses in Wailing Caverns to be able to start event, talk to Disciple of Naralex...

Client version: 2.4.3

Commit hash: https://github.com/cmangos/mangos-tbc/commit/190221606936b044e32ebd737ff5c01cd7049983

Database version: Latest TBC-DB

Operating system: Debian 8.6 amd64

[killerwife]

I have a fix for this, but its a core issue. Hold on.

[killerwife]

GossipSelect_npc_disciple_of_naralex function Remove pCreature->SetFactionTemporary(FACTION_ESCORT_N_ACTIVE, TEMPFACTION_RESTORE_RESPAWN);

After that it works as intended afaik. @cyberium in case you would want to close this issue :)

[Tobschinski]

What faction does he have in that screenshot?

[killerwife]

Who knows, I just know when I made that change that he should be friendly to players.

[Tobschinski]

Well, FACTION_ESCORT_N_ACTIVE = 250 is also super friendly (and appropriate) ... I just did the event with no issues at all (in vanilla though).

[killerwife]

That does not really help.

[Rushor]

FACTION_ESCORT_N_ACTIVE = 250 is used very often in serveral escortquests (horde and alliance will be friendly but monsters will be hostile towards the escortnpc)

[Tobschinski]

The reason to request more info. This does not look like faction 35 or 250 and nothing else should be used.

[killerwife]

I suggest you log on to TBC and look for yourself.

[Tobschinski]

Or I just wait for thrd92 to answer my initial question ... if he can find it now.

[thrd92]

@Tobschinski Looks like the NPC is neutral (yellow unit frame) during the event, before the event NPC has green unit frame, so he's friendly at least. Gonna check .npc info output, brb.

[thrd92]

So, before event faction is 35, during the event faction is 1986.

[Tobschinski]

Makes sense because of this, thank you!

I'd suggest to use FACTION_ESCORT_N_NEUTRAL_ACTIVE = 250 then.

[killerwife]

Do we need to change faction? I mean this is sniff territory.

[Tobschinski]

I can only offer you one from MOP.

[0] UpdateType: Values
[0] Object Guid: Full: - Creature/0 -/- Map: - Entry: 3678 Low: -
[0] UNIT_FIELD_FACTIONTEMPLATE: 250/3.503246E-43
[0] UNIT_NPC_FLAGS: 0/0

[killerwife]

Yes but before that the whole event was changed. So it isnt reliable imo.

[Rushor]

i will search for an older sniff - bump me in this issue after 10 days if i forgot it

[drikishuk]

Bump @Rushor