[CLASSIC][TBC][WOTLK] Deprecation of Database Tables

[killerwife]

creature_movement creature_movement_template - tbc-db has removed last usage of the old deprecated fields. I want to remove them now @Grz3s @cala opinions?

Also, questgiver_greeting will soon be exported, it enables full npc_gossip deprecation, would be nice if CDB and WDB worked on removing all its data afterwards.

[cyberium]

didn't read the issue but knowing the author is enough for me to close this.

[killerwife]

Troll.

[Grz3s]

WoTLDB.. fixed old data from creature_movement creature_movement_template long time ago. textid1 - textid5 emote spell model1 - model2

About npc_gossip -- i dont think thats a good idea to remove it.. theyre lots of gossips that correct ids were never found.

[cala]

Clean-up was made also in Classic DB. So feel free to proceed on the removal of deprecated fields.

Regarding npc_gossip I agree with @Grz3s : either we let it untouched, either we move them to npc_text/gossip_menu but with using placeholder IDs.

[killerwife]

It already uses placeholder IDs, but not database-side, but core-side. @Mantislord already removed plenty on our end, and it just needs more research. The #1 reason i want to remove it is because many of them are supposed to be in questgiver_greeting and the rest should be in npc_text and gossip_menu. npc_gossip uses npc_text but only assigns it to ONE guid of given creature_template, which we know is wrong. As a result needs to be nuked asap because its not blizzlike.

[AnonXS]

https://github.com/cmangos/mangos-classic/blob/746691ddc925a91e0294e7333258f47a30d8ab7b/sql/updates/mangos/z2712_01_mangos_creature_movement_drops.sql

https://github.com/cmangos/mangos-tbc/blob/b4dcb0f4782babf0147f764a77e533eb375bb2fc/sql/updates/mangos/s2363_01_mangos_creature_movement_drops.sql

https://github.com/cmangos/mangos-wotlk/blob/7736f715aaaf0f43c36b560f65a3c08d67335b9b/sql/updates/mangos/13966_01_mangos_creature_movement_drops.sql

closed