search

cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
180 stars 47 forks source link

[CLASSIC] Quest 5163: Are We There Yeti? #1492

Open bdebaere opened 7 years ago

bdebaere commented 7 years ago

Current behavior: The item http://www.wowhead.com/item=12928/umis-mechanical-yeti does not scare the creatures you use it on. It just gives credit.

Expected behavior: When using the item the creature should run and yell. Like in this implementation: https://github.com/TrinityCore/TrinityCore/issues/10972. I'm not sure how CMangos feels about blindly copying an implementation.

Steps to reproduce:

  1. Accept quest 5163.
  2. Use item on Legacki in Everlook.
  3. See how it does not scare him, just gives credit.

Client version: 1.12.1 Commit hash:

Database version:

Operating system:

brotalnia commented 7 years ago

You can also look at https://github.com/LightsHope/server/commit/fcbfd34e7534a7e5185797242ddd260dc6dd3ad6.

killerwife commented 7 years ago

Copying is fine, as long as proper credit/mention is awarded. The only thing that must be mentioned is that every implementation needs to be question, and examined. If it's correct, based on all the possibly available info (who am kidding, this is vanilla, we only have breadcrumbs, not proper data like in tbc/wotlk), then you can port it with no remorse. For example i ported TC music Gameobjects recently.

bdebaere commented 6 years ago

@brotalnia Repository unavailable due to DMCA takedown.

brotalnia commented 6 years ago

https://github.com/ratkosrb/server/commit/fcbfd34e7534a7e5185797242ddd260dc6dd3ad6