search

cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
180 stars 48 forks source link

Crash using postgresql during startup #1722

Closed Lillecarl closed 6 years ago

Lillecarl commented 6 years ago

If there are null values in column text in tables questgiver_greeting or trainer_greeting cmangos will crash. If you start it with PostgreSQL as a backend, tbc-db converted using pgloader.

I suggest we alter these tables so they can't hold null, but empty string instead, thoughts?

cyberium commented 6 years ago

I suggest not supporting PostgreSQL instead?

Lillecarl commented 6 years ago

Considering the psql wire protocol is being used for some really cool databases these days (see cockroach for example) I don't agree, but it's definitely a low priority issue. Why do we allow these tables to be null though?

A personal opinion is that postgresql these days is way more attractive than MySQL considering all different MySQL versions (oracle, Mariadb 5, mariadb 10 which we're only part compatible with).